Make IntoPy conversion fallible #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## main #639 +/- ##
=======================================
Coverage 94.78% 94.79%
=======================================
Files 245 245
Lines 25281 25289 +8
=======================================
+ Hits 23963 23973 +10
+ Misses 1318 1316 -2
Continue to review full report at Codecov.
|
1 task
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR creates a new TryIntoPy trait which is a fallible version of IntoPy. It's an uncivilized, special-purpose version of the trait discussed here: PyO3/pyo3#1813
The point is to avoid panicking while converting the parsed CST back into Python-land when an exception is encountered during conversion; this panic is important to avoid because in some multiprocessing scenarios it can cause a crash.
While we're at it, this PR simplifies the proc-macro deriving: the new
TryIntoPytrait convertsVecdirectly intoPyTupleinstead of a list.Test Plan
Added a test to exercise the exception being thrown.